[Intel-gfx] [PATCH 8/8] drm/i915: NULL check of unpin_work

Daniel Vetter daniel at ffwll.ch
Fri Oct 9 01:39:37 PDT 2015


On Fri, Oct 09, 2015 at 08:46:31AM +0100, Chris Wilson wrote:
> On Thu, Oct 08, 2015 at 07:31:40PM +0100, Tomas Elf wrote:
> > Avoid NULL pointer exceptions in the display driver for certain critical cases
> > when unpin_work has turned out to be NULL.
> 
> Nope, the machine reached a point where it cannot possibly reach, we
> want the OOPS.

Yeah this looks funky ... how did you get to that state? If it indeed
blows up in testing then we'd need at least a WARN_ON (and hopefully some
ideas what's going wrong).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list