[Intel-gfx] [PATCH 8/8] drm/i915: NULL check of unpin_work

Tomas Elf tomas.elf at intel.com
Fri Oct 9 04:50:01 PDT 2015

On 09/10/2015 09:39, Daniel Vetter wrote:
> On Fri, Oct 09, 2015 at 08:46:31AM +0100, Chris Wilson wrote:
>> On Thu, Oct 08, 2015 at 07:31:40PM +0100, Tomas Elf wrote:
>>> Avoid NULL pointer exceptions in the display driver for certain critical cases
>>> when unpin_work has turned out to be NULL.
>> Nope, the machine reached a point where it cannot possibly reach, we
>> want the OOPS.
> Yeah this looks funky ... how did you get to that state? If it indeed
> blows up in testing then we'd need at least a WARN_ON (and hopefully some
> ideas what's going wrong).
> -Daniel

I have no idea but I know that it blew up my machine and ended my test 
ahead of time. Adding this check allows me to test for 12+ hours, which 
is what I wanted to do.

Sure, I'll add a WARN_ON. I don't know how much time I have to 
investigate the root cause considering the whole TDR upstreaming situation.


More information about the Intel-gfx mailing list