[Intel-gfx] [PATCH 8/8] drm/i915: NULL check of unpin_work

Tomas Elf tomas.elf at intel.com
Fri Oct 9 03:30:34 PDT 2015

On 09/10/2015 08:46, Chris Wilson wrote:
> On Thu, Oct 08, 2015 at 07:31:40PM +0100, Tomas Elf wrote:
>> Avoid NULL pointer exceptions in the display driver for certain critical cases
>> when unpin_work has turned out to be NULL.
> Nope, the machine reached a point where it cannot possibly reach, we
> want the OOPS.
> -Chris

Really? Because if I have this in there I can actually run the 
long-duration stability tests for 12+ hours rather than just a few hours 
(it doesn't happen all the time but I've seen it at least once). But, 
hey, if you want to investigate the reason why we have a NULL there then 
go ahead. I guess I'll just have to carry this patch for as long as my 
machine crashes during my TDR testing.


More information about the Intel-gfx mailing list