[Intel-gfx] [PATCH v2 4/5] drm/i915: Make updating pipe without modeset atomic.

Jesse Barnes jbarnes at virtuousgeek.org
Thu Sep 10 12:31:03 PDT 2015


On 08/27/2015 06:44 AM, Maarten Lankhorst wrote:
> +	/* on skylake this is done by detaching scalers */
> +	if (INTEL_INFO(dev)->gen == 9) {
> +		skl_detach_scalers(crtc);
> +
> +		if (pipe_config->pch_pfit.enabled)
> +			skylake_pfit_enable(crtc);
> +	}
> +	else if (INTEL_INFO(dev)->gen < 9 &&
> +	         HAS_PCH_SPLIT(dev)) {
> +		if (pipe_config->pch_pfit.enabled)
> +			ironlake_pfit_enable(crtc);
> +		else if (old_crtc_state->pch_pfit.enabled)
> +			ironlake_pfit_disable(crtc, true);
>  	}

Funky coding style, but otherwise looks ok...

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>


More information about the Intel-gfx mailing list