[Intel-gfx] [PATCH v2 4/5] drm/i915: Make updating pipe without modeset atomic.

[Daniel Vetter]

On Thu, Sep 10, 2015 at 12:31:03PM -0700, Jesse Barnes wrote:
> On 08/27/2015 06:44 AM, Maarten Lankhorst wrote:
> > +	/* on skylake this is done by detaching scalers */
> > +	if (INTEL_INFO(dev)->gen == 9) {
> > +		skl_detach_scalers(crtc);
> > +
> > +		if (pipe_config->pch_pfit.enabled)
> > +			skylake_pfit_enable(crtc);
> > +	}
> > +	else if (INTEL_INFO(dev)->gen < 9 &&
> > +	         HAS_PCH_SPLIT(dev)) {
> > +		if (pipe_config->pch_pfit.enabled)
> > +			ironlake_pfit_enable(crtc);
> > +		else if (old_crtc_state->pch_pfit.enabled)
> > +			ironlake_pfit_disable(crtc, true);
> >  	}
> 
> Funky coding style, but otherwise looks ok...

Yeah I simplified this and future-proved it to make the skl_* be called
for gen9+.

But I did spot that the check for scaler_id in the pipe config compare
function is not in the !adjust block ... does fastboot on skl actually
work?

Thanks, Daniel

> 
> Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch