[Intel-gfx] [PATCH i-g-t 2/2] tests/kms_flip: Half the duration time for basic-*vs-modeset/flip tests.
Marius Vlad
marius.c.vlad at intel.com
Thu Apr 21 10:08:24 UTC 2016
Grr, both of them take 2minutes, 1 minute each. What I meant was 30s
each. Got distracted a little bit, that the duration is adjusted to ms
further down the call.
On Thu, Apr 21, 2016 at 11:23:26AM +0200, Daniel Vetter wrote:
> On Wed, Apr 20, 2016 at 08:49:57PM +0300, Marius Vlad wrote:
> > basic-flip-vs-dpms and basic-flip-vs-modeset together take roughly 2m
> > to run. Adjust the duration time to a maximum of 500ms.
>
> Can we have a notch more please? Ime it takes generally a few modesets for
> this thing to fall over (2-3 modesets), are you sure the test still does
> something useful in half a second? Mostly a modeset takes a lot longer
> than that.
Definitely not half a second...
>
> Also you just half the duration, but claim it goes from 2minutes to 500 ms
> ...
>
> I'm confused.
> -Daniel
>
> >
> > Signed-off-by: Marius Vlad <marius.c.vlad at intel.com>
> > ---
> > tests/kms_flip.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> > index 3d44544..fd8206f 100644
> > --- a/tests/kms_flip.c
> > +++ b/tests/kms_flip.c
> > @@ -1458,7 +1458,7 @@ static int run_test(int duration, int flags)
> > }
> >
> > igt_require(modes);
> > - duration = duration * 1000 / modes;
> > + duration = duration * 500 / modes;
> > duration = max(500, duration);
> >
> > /* Find any connected displays */
> > --
> > 2.5.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20160421/00e1cb34/attachment.sig>
More information about the Intel-gfx
mailing list