[Intel-gfx] [PATCH 1/4] drm: Protect master->unique with dev->master_mutex

[Michel Dänzer]

On 13/12/16 05:35 PM, Daniel Vetter wrote:
> On Mon, Dec 12, 2016 at 01:23:46PM +0000, Emil Velikov wrote:
>> On 10 December 2016 at 21:52, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
>>> No one looks at the major/minor versions except the unique/busid
>>> stuff. If we protect that with the master_mutex (since it also affects
>>> the unique of each master, oh well) we can mark these two IOCTL with
>>> DRM_UNLOCKED.
>>>
>>> While doing this I realized that the comment for the magic_map is
>>> outdated, I've forgotten to update it in:
>>>
>>> commit d2b34ee62b409a03c6fe43c07b779983be51d017
>>> Author: Daniel Vetter <daniel.vetter at ffwll.ch>
>>> Date:   Fri Jun 17 09:33:21 2016 +0200
>>>
>>>     drm: Protect authmagic with master_mutex
>>>
>>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>>> Cc: Emil Velikov <emil.l.velikov at gmail.com>
>>> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
>> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
>>
>> Side note: I've looked at "fixing" xf86-video-amdgpu and so far I'm at
>> ~25 patches. Admittedly it includes some related fixes/cleanups.
>> At some point we want to address the other KMS ddx - armsoc (ahem),
>> ati, freedreno, intel, nouveau, omap, opentegra, vmwgfx, qxl and of
>> course modesetting ;-)
>> Regardless if some are superseded and/or barely used.
> 
> Hm, I thought the grand plan is to use -modesetting almost everywhere and
> forget about all the others?

Maybe if you mean s/grand plan/pipe dream/ ...

Specifically, wrt to DDX drivers for ATI/AMD GPUs:

xf86-video-ati supports old GPUs on which glamor can't work, so
-modesetting can never be a complete replacement.

xf86-video-amdgpu is also used by the amdgpu-pro stack, with
modifications which are probably unsuitable for -modesetting. There's
also still a feature gap to -modesetting, e.g. the latter doesn't
support TearFree yet, and there doesn't seem to be any interest to fix that.

So I'm afraid we can't get rid of those anytime soon, if ever.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer