[Intel-gfx] [PATCH i-g-t] tests: Adding kms_dp_aux_dev test.

[Ville Syrjälä]

On Fri, Feb 19, 2016 at 04:24:34PM -0500, Rafael Antognolli wrote:
> This new test makes some basic testing on the proposed drm_dp_aux_dev
> interface. If the feature is enabled and the drm_dp_aux_dev class is
> present, it will check for available DP aux channels and test them for:
> 	- basic seek to 0 and read 1 byte
> 	- seek to the last address and read, to confirm 0 is returned
> 	- seek one more byte and confirm that EINVAL is returned
> 	- try to read 64 bytes when at 8 bytes from the end of the
> 	address space
> 	- try to read 64 bytes at the address 0.

Maybe also check with lseek(SEEK_CUR,0) after a read that the current
file offset was incremented correclty by the read.

Also maybe read some well known offset(s) to verify the data looks
correct. The DPCD version seems like the most obvious candidate,
except it's at offset 0 so doesn't really verify that seeking works
correctly. The other two offsets I can think of that should have
a decently limited set of values are max link rate and max lane
count. I'm not sure there's anything mandatory and recognizable
further along.

> 
> So far, no write checks are done.
> 
> Signed-off-by: Rafael Antognolli <rafael.antognolli at intel.com>
> ---
>  tests/Makefile.sources |   1 +
>  tests/kms_dp_aux_dev.c | 177 +++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 178 insertions(+)
>  create mode 100644 tests/kms_dp_aux_dev.c
> 
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index f8b18b0..7920e23 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -79,6 +79,7 @@ TESTS_progs_M = \
>  	kms_atomic \
>  	kms_chv_cursor_fail \
>  	kms_cursor_crc \
> +	kms_dp_aux_dev \
>  	kms_draw_crc \
>  	kms_fbc_crc \
>  	kms_fbcon_fbt \
> diff --git a/tests/kms_dp_aux_dev.c b/tests/kms_dp_aux_dev.c
> new file mode 100644
> index 0000000..92e96dd
> --- /dev/null
> +++ b/tests/kms_dp_aux_dev.c
> @@ -0,0 +1,177 @@
> +/*
> + * Copyright © 2015 Intel Corporation

Bump the year?

> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + */
> +
> +/** @file kms_dp_aux_dev.c
> + *
> + * This is a test of functionality of drm_dp_aux_dev.
> + */
> +
> +#include "igt.h"
> +#include <stdlib.h>
> +#include <stdio.h>
> +#include <dirent.h>
> +#include <unistd.h>
> +#include <sys/stat.h>
> +#include <fcntl.h>
> +
> +#include <drm.h>
> +
> +#define MAX_CONNECTORS 32
> +#define DRM_DP_AUX_SYSFS_PATH "/sys/class/drm_dp_aux_dev"
> +
> +IGT_TEST_DESCRIPTION("Test of drm_aux_dev nodes.");
> +
> +static void seek_too_far(int fd)
> +{
> +	off_t address;
> +	uint8_t buf;
> +	uint8_t bigbuf[64];
> +	ssize_t res;
> +
> +	/* Test reads on the end of address space */
> +	address = lseek(fd, 0, SEEK_END);
> +	igt_assert_eq(address, 1 << 20);
> +	res = read(fd, &buf, sizeof(buf));
> +	igt_assert_eq(res, 0);
> +
> +	address = lseek(fd, 1, SEEK_CUR);
> +	igt_assert_eq(address, -1);
> +	igt_assert_eq(errno, EINVAL);
> +
> +	address = lseek(fd, -8, SEEK_END);
> +	res = read(fd, bigbuf, sizeof(bigbuf));
> +	igt_assert_eq(res, 8);
> +}
> +
> +static void read_large_chunk(int fd)
> +{
> +	uint8_t bigbuf[64];
> +	ssize_t res;
> +
> +	/* Test reading more than 16 bytes at once */
> +	lseek(fd, 0, SEEK_SET);
> +	res = read(fd, bigbuf, sizeof(bigbuf));
> +	igt_assert_eq(res, sizeof(bigbuf));
> +}
> +
> +static void basic_seek_and_read(int fd)
> +{
> +	char buf;
> +	ssize_t res;
> +	off_t address;
> +
> +	address = lseek(fd, 0x0, SEEK_SET);
> +	igt_assert_eq(address, 0x0);
> +
> +	res = read(fd, &buf, sizeof(buf));
> +	igt_assert_eq(res, sizeof(buf));
> +}
> +
> +static int count = 0;
> +static int fds[MAX_CONNECTORS];
> +static bool checked_connections = false;
> +static bool connected[MAX_CONNECTORS];
> +
> +static bool check_aux_connected(int fd)
> +{
> +	char buf;
> +	ssize_t res;
> +
> +	res = read(fd, &buf, sizeof(buf));
> +	igt_assert(res >= 0 || errno == ETIMEDOUT);
> +	if (res < 0 && errno == ETIMEDOUT)
> +		return false;
> +	else
> +		return true;
> +}
> +
> +static void for_each_dp_aux(void (*fn)(int))
> +{
> +	int i;
> +	int total = 0;
> +
> +	for (i = 0; i < count; i++) {
> +		igt_assert_fd(fds[i]);
> +
> +		/* The first time that this loop is executed, check if each aux
> +		 * dp is connected and store that result for the next pass
> +		 */
> +		if (!checked_connections)
> +			connected[i] = check_aux_connected(fds[i]);
> +
> +		if (connected[i]) {
> +			fn(fds[i]);
> +			total++;
> +		}
> +	}
> +
> +	checked_connections = true;
> +
> +	igt_require(total > 0);
> +}
> +
> +igt_main
> +{
> +	struct stat st;
> +	DIR *dir = NULL;
> +
> +	igt_fixture {
> +		struct dirent *dirent;
> +		const char basedir[] = "/dev/";
> +		size_t len_base = sizeof(basedir);
> +
> +		igt_require(stat(DRM_DP_AUX_SYSFS_PATH, &st) == 0);
> +		igt_require(S_ISDIR(st.st_mode));
> +
> +		dir = opendir(DRM_DP_AUX_SYSFS_PATH);
> +		igt_require(dir);
> +
> +		/* store each dp aux dev for later use */
> +		while ((dirent = readdir(dir))) {
> +			char entry[len_base + NAME_MAX];
> +			if (dirent->d_name[0] == '.')
> +				continue;
> +
> +			snprintf(entry, sizeof(entry), "%s%s", basedir, dirent->d_name);
> +			fds[count] = open(entry, O_RDONLY);
> +			count++;
> +		}
> +		igt_require(count > 0);
> +	}
> +
> +	igt_subtest("basic_seek_and_read")
> +		for_each_dp_aux(basic_seek_and_read);
> +
> +	igt_subtest("seek-too-far")
> +		for_each_dp_aux(seek_too_far);
> +
> +	igt_subtest("read-large-chunk")
> +		for_each_dp_aux(read_large_chunk);

These kinds of tests shouldn't take too long I would think, so
maybe make them all basic?

> +
> +	igt_fixture {
> +		int i;
> +		for (i = 0; i < count; i++)
> +			close(fds[i]);
> +		closedir(dir);
> +	}
> +}
> -- 
> 2.5.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC