[Intel-gfx] [PATCH 7/7] drm/i915: GEM operations need to be done under the big lock

Chris Wilson chris at chris-wilson.co.uk
Mon Jan 11 08:56:37 PST 2016


On Mon, Jan 11, 2016 at 05:36:46PM +0200, Ville Syrjälä wrote:
> On Mon, Jan 11, 2016 at 03:16:16PM +0000, Tvrtko Ursulin wrote:
> > Don't know, I leave this one to whoever grabbed the lock around 
> > intel_init_gt_powersave in the first place. Maybe there was a special 
> > reason.. after git blame od intel_display.c eventually completed, adding 
> > Imre and Ville to cc.
> 
> Hmm. I don't recall the details anymore, but looking at the code pushing
> the locking down to valleyview_setup_pctx() looks entirely reasonable to
> me.

iirc, this locking only exists to keep the WARN() at bay. But it is
pedagogical, I guess.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list