[Intel-gfx] [PATCH] drm/i915: Sink CRC: tune down error message at stop to debug_kms.

Daniel Vetter daniel at ffwll.ch
Tue Jan 19 02:15:44 PST 2016

On Wed, Jan 13, 2016 at 02:05:04PM -0800, Rodrigo Vivi wrote:
> When we stop the sink CRC calculation we wait a while until the counter
> is reset to zero and return -ETIMEDOUT. However the sink crc was
> calculated already by this point so we just ignore this return at
> the main function.
> So, let's also ignore the message and put it as a debug message instead
> of an error one. The message might still be useful when debuging
> test failures so we could be able to know something was not going so
> well with sink crc stop.
> Reference: https://bugs.freedesktop.org/show_bug.cgi?id=93694
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index c8f58ab..22f6887 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -4009,7 +4009,7 @@ static int intel_dp_sink_crc_stop(struct intel_dp *intel_dp)
>  	} while (--attempts && count);
>  	if (attempts == 0) {
> -		DRM_ERROR("TIMEOUT: Sink CRC counter is not zeroed\n");
> +		DRM_DEBUG_KMS("TIMEOUT: Sink CRC counter is not zeroed\n");
>  		ret = -ETIMEDOUT;

Iirc the real problem is that we even try to run the testcase with no eDP
panel present. I think fixing up the igt_require logic to correctly skip
is the right fix here, not just shutting up the kernel about it.

Or maybe the bug is that we register an edp connector when there is none?
Daniel Vetter
Software Engineer, Intel Corporation

More information about the Intel-gfx mailing list