[Intel-gfx] [PATCH 1/2] drm/i915: Rename GGTT init functions

Chris Wilson chris at chris-wilson.co.uk
Wed Mar 23 16:06:09 UTC 2016


On Wed, Mar 23, 2016 at 06:02:34PM +0200, Ville Syrjälä wrote:
> On Wed, Mar 23, 2016 at 05:54:09PM +0200, Mika Kuoppala wrote:
> > Ville Syrjälä <ville.syrjala at linux.intel.com> writes:
> > 
> > > [ text/plain ]
> > > On Wed, Mar 23, 2016 at 03:00:22PM +0200, Joonas Lahtinen wrote:
> > >> Rename and document the GGTT init functions to give a better
> > >> idea of the context where they are called from.
> > >> 
> > >> i915_gem_gtt_init => i915_init_ggtt_hw
> > >
> > > Seems to me i915_ggtt_init_hw would match existing practices better.
> > >
> > 
> > There is also some gravity towards putting the verb first. In gem
> > side atleast.
> 
> At least in this case ggtt_init_hw would match ppgtt_init_hw, which
> seems like a nice thing.

It would also help with the plan to tag the init_hw phases consistently.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list