[Intel-gfx] [PATCH 0/2] drm/i915: Split up modeset state checker.

Matt Roper matthew.d.roper at intel.com
Fri Mar 25 16:59:30 UTC 2016

On Wed, Mar 23, 2016 at 02:58:05PM +0100, Maarten Lankhorst wrote:
> Right now the state checker assumes that the global state is fixed,
> with support for the atomic ioctl not all state will be locked any more,
> so the state checker has to check only what's part of the state.
> This is done by first splitting up the state checker in one part that
> checks all disabled connectors/encoders and global state, and then
> split again to run for each crtc separately.

While you're touching these functions, maybe it would be a good time to
rename them as well?  The 'check' in their names can mislead people into
thinking that they're somehow related to the atomic 'check' phase, even
though they're actually something we do after the commit is complete.

Renaming these with  s/check/confirm/ or s/check/verify/ might make it a
little bit easier to understand what their purpose is and avoid


> Maarten Lankhorst (2):
>   drm/i915: Make modeset state checker take crtc as argument.
>   drm/i915: Move modeset state checker calls.
>  drivers/gpu/drm/i915/intel_display.c | 310 +++++++++++++++++++----------------
>  1 file changed, 173 insertions(+), 137 deletions(-)
> -- 
> 2.1.0
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795

More information about the Intel-gfx mailing list