[Intel-gfx] [PATCH 0/2] drm/i915: Split up modeset state checker.

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Tue Mar 29 07:33:13 UTC 2016

Op 25-03-16 om 17:59 schreef Matt Roper:
> On Wed, Mar 23, 2016 at 02:58:05PM +0100, Maarten Lankhorst wrote:
>> Right now the state checker assumes that the global state is fixed,
>> with support for the atomic ioctl not all state will be locked any more,
>> so the state checker has to check only what's part of the state.
>> This is done by first splitting up the state checker in one part that
>> checks all disabled connectors/encoders and global state, and then
>> split again to run for each crtc separately.
> While you're touching these functions, maybe it would be a good time to
> rename them as well?  The 'check' in their names can mislead people into
> thinking that they're somehow related to the atomic 'check' phase, even
> though they're actually something we do after the commit is complete.
> Renaming these with  s/check/confirm/ or s/check/verify/ might make it a
> little bit easier to understand what their purpose is and avoid
> confusion.
I'm ok with s/check/verify/ -- anything wrong with the patches itself?

More information about the Intel-gfx mailing list