[Intel-gfx] [PATCH 5/6] drm/atomic: use connector references (v2)

Dave Airlie airlied at gmail.com
Tue May 3 10:09:51 UTC 2016


>>        */
>> +     if (connector && state->crtc) {
>> +             drm_connector_unreference(state->connector);
>> +     }
>
> Bikeshed: no need for {} and you don't need to check that connector is
> NULL either. Tbh all the destroy_state helpers don't really need their
> object argument, only the state. Cleaning that up is somewhere on my todo.

Yes you really do need the connector, lost a boot to an oops,

drm_atomic_state_default_clear does some funky stuff that can possibly go away
after this, but I'm not sure.

Dave.


More information about the Intel-gfx mailing list