[Intel-gfx] [PATCH 5/6] drm/atomic: use connector references (v2)

[Daniel Vetter]

On Tue, May 3, 2016 at 12:09 PM, Dave Airlie <airlied at gmail.com> wrote:
>>>        */
>>> +     if (connector && state->crtc) {
>>> +             drm_connector_unreference(state->connector);
>>> +     }
>>
>> Bikeshed: no need for {} and you don't need to check that connector is
>> NULL either. Tbh all the destroy_state helpers don't really need their
>> object argument, only the state. Cleaning that up is somewhere on my todo.
>
> Yes you really do need the connector, lost a boot to an oops,
>
> drm_atomic_state_default_clear does some funky stuff that can possibly go away
> after this, but I'm not sure.

Surprising, didn't expect that. Do you still have the backtrace
somewhere? I really wonder what goes boom with that one ...

What we might need is check for state->connector (instead of
connector), but that being NULL for a valid state is also a bit a bug.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch