[Intel-gfx] [PATCH] drm/i915/guc: Do not bypass forcewakes in i915_guc_submit

Tvrtko Ursulin tursulin at ursulin.net
Thu Nov 17 09:17:35 UTC 2016


From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Commit ed4596ea992d ("drm/i915/guc: WA to address the Ringbuffer
coherency issue"), based on incorrect assumptions from a partialy
broken commit 0dd356bb6ff5 ("drm/i915: Eliminate Gen9 special
case") used POSTING_READ_FW instead of the POSTING_READ. With the
latter buggy commit fixed this call site needs fixing as well.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
Fixes: ed4596ea992d ("drm/i915/guc: WA to address the Ringbuffer coherency issue")
Reported-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
Cc: Akash Goel <akash.goel at intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Sagar Arun Kamble <sagar.a.kamble at intel.com>
---
 drivers/gpu/drm/i915/i915_guc_submission.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/i915/i915_guc_submission.c
index 4462112725ef..c603837324a0 100644
--- a/drivers/gpu/drm/i915/i915_guc_submission.c
+++ b/drivers/gpu/drm/i915/i915_guc_submission.c
@@ -651,7 +651,7 @@ static void i915_guc_submit(struct drm_i915_gem_request *rq)
 
 	/* WA to flush out the pending GMADR writes to ring buffer. */
 	if (i915_vma_is_map_and_fenceable(rq->ring->vma))
-		POSTING_READ_FW(GUC_STATUS);
+		POSTING_READ(GUC_STATUS);
 
 	b_ret = guc_ring_doorbell(client);
 
-- 
2.7.4



More information about the Intel-gfx mailing list