[Intel-gfx] [PATCH] drm/i915: Fix gen9 forcewake range table

[Tvrtko Ursulin]

On 17/11/2016 12:50, Chris Wilson wrote:
> On Thu, Nov 17, 2016 at 09:02:43AM +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>
>> Commit 0dd356bb6ff5 ("drm/i915: Eliminate Gen9 special case")
>> accidentaly dropped a MMIO range between 0xc000 to 0xcfff out
>> of the blitter forcewake domain. Fix it.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> Fixes: 0dd356bb6ff5 ("drm/i915: Eliminate Gen9 special case")
>> Reported-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
>> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_uncore.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
>> index e953303bff54..a0944dde7c41 100644
>> --- a/drivers/gpu/drm/i915/intel_uncore.c
>> +++ b/drivers/gpu/drm/i915/intel_uncore.c
>> @@ -789,7 +789,7 @@ static const struct intel_forcewake_range __gen9_fw_ranges[] = {
>>  	GEN_FW_RANGE(0x9400, 0x97ff, FORCEWAKE_RENDER | FORCEWAKE_MEDIA),
>>  	GEN_FW_RANGE(0x9800, 0xafff, FORCEWAKE_BLITTER),
>>  	GEN_FW_RANGE(0xb000, 0xb47f, FORCEWAKE_RENDER),
>> -	GEN_FW_RANGE(0xb480, 0xbfff, FORCEWAKE_BLITTER),
>> +	GEN_FW_RANGE(0xb480, 0xcfff, FORCEWAKE_BLITTER),
>>  	GEN_FW_RANGE(0xd000, 0xd7ff, FORCEWAKE_MEDIA),
>
> The table should be watertight...
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
>
> So, possible to test in intel_fw_table_check()?

Yep, a good idea, essential even. I've sent a separate patch for that.

Regards,

Tvrtko