[Intel-gfx] [PATCH 18/42] drm/i915: Move object backing storage manipulation to its own locking

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Thu Oct 13 12:46:04 UTC 2016


On pe, 2016-10-07 at 10:46 +0100, Chris Wilson wrote:
> @@ -4211,10 +4240,10 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
>  		i915_gem_object_truncate(obj);
>  
>  	args->retained = obj->mm.madv != __I915_MADV_PURGED;
> +	mutex_unlock(&obj->mm.lock);
>  
> +err:

Shared, so 'out:'

Other than that, looks good.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Am I to assume that now when we introduced a new lock, every single
function that assumes the lock taken is now tagged with
assert_lockdep_held?

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list