[Intel-gfx] [PATCH 18/42] drm/i915: Move object backing storage manipulation to its own locking

[Chris Wilson]

On Thu, Oct 13, 2016 at 03:46:04PM +0300, Joonas Lahtinen wrote:
> On pe, 2016-10-07 at 10:46 +0100, Chris Wilson wrote:
> > @@ -4211,10 +4240,10 @@ i915_gem_madvise_ioctl(struct drm_device *dev, void *data,
> >  		i915_gem_object_truncate(obj);
> >  
> >  	args->retained = obj->mm.madv != __I915_MADV_PURGED;
> > +	mutex_unlock(&obj->mm.lock);
> >  
> > +err:
> 
> Shared, so 'out:'
> 
> Other than that, looks good.
> 
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> 
> Am I to assume that now when we introduced a new lock, every single
> function that assumes the lock taken is now tagged with
> assert_lockdep_held?

There's are two external calls that assume the caller holds the obj->mm.lock,
and yes they are so marked.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre