[Intel-gfx] [PATCH v2 01/11] drm/i915/skl+: Prepare for removing data rate from skl watermark state, v2.

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Thu Oct 27 08:31:01 UTC 2016


Op 27-10-16 om 09:12 schreef Daniel Vetter:
> On Wed, Oct 26, 2016 at 03:41:29PM +0200, Maarten Lankhorst wrote:
>> Changes since v1:
>> - Remove plane->pipe checks, they're implied by the macros.
>> - Split unrelated changes to a separate commit.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Drive-by review: The above commit message is way too thin. It prepares for
> something, but I can't make any connection at all to that something. 1-2
> sentences about why are needed here I think.

Hm, seems to have been lost somewhere. It was on my previous submission:

Caching is not required, drm_atomic_crtc_state_for_each_plane_state
can be used to inspect all plane_states that are assigned to the
current crtc_state, so we can just recalculate every time.

~Maarten



More information about the Intel-gfx mailing list