[Intel-gfx] [PATCH 2/2] drm/i915/gtt: Mark tlbs dirty on clear

Mika Kuoppala mika.kuoppala at linux.intel.com
Mon Oct 31 15:58:15 UTC 2016


Chris Wilson <chris at chris-wilson.co.uk> writes:

> On Mon, Oct 31, 2016 at 05:24:46PM +0200, Mika Kuoppala wrote:
>> Now when clearing ptes can modify upper level pdp's,
>> we need to mark them dirty so that they will be flushed
>> correctly.
>
> I suppose so.

It is a bit iffy if we really do, but this way we gain symmetry
with the alloc side.

I pondered why this is missing from 4l side, but in there the
topmost pointer is static.

-Mika

> I think we could push this into the cleanup_px() (and
> alloc) but that is probably a fair chunk of work for immeasurable gain.
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> -Chris
>
> -- 
> Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list