[Intel-gfx] [PATCH] drm/i915: Keep track of active forcewake domains in a bitmask

Chris Wilson chris at chris-wilson.co.uk
Tue Sep 27 12:26:34 UTC 2016


On Tue, Sep 27, 2016 at 01:11:50PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> There are current places in the code, and there will be more in the
> future, which iterate the forcewake domains to find out which ones
> are currently active.
> 
> To save them from doing this iteration, we can cheaply keep a mask
> of active domains in dev_priv->uncore.fw_domains_active.
> 
> This has no cost in terms of object size, even manages to shrink it
> overall by 368 bytes on my config.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Cc: "Paneri, Praveen" <praveen.paneri at intel.com>

Looks solid and should not run afoul of the games played during reset or
suspend.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list