[Intel-gfx] [PATCH] drm/i915: Keep track of active forcewake domains in a bitmask

[Tvrtko Ursulin]

On 27/09/2016 13:26, Chris Wilson wrote:
> On Tue, Sep 27, 2016 at 01:11:50PM +0100, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>
>> There are current places in the code, and there will be more in the
>> future, which iterate the forcewake domains to find out which ones
>> are currently active.
>>
>> To save them from doing this iteration, we can cheaply keep a mask
>> of active domains in dev_priv->uncore.fw_domains_active.
>>
>> This has no cost in terms of object size, even manages to shrink it
>> overall by 368 bytes on my config.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> Cc: "Paneri, Praveen" <praveen.paneri at intel.com>
> Looks solid and should not run afoul of the games played during reset or
> suspend.
>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Thanks!

Praveen, you can see if this patch would help for your decoupled MMIO 
patches, and if you like it you can incrorporate it in your series if 
you want?

Regards,

Tvrtko