[Intel-gfx] [PATCH 6/6] [v4] drm/i915: Add support for CCS modifiers

[Ben Widawsky]

On 17-08-03 12:00:56, Daniel Stone wrote:
>Hi,
>
>On 1 August 2017 at 17:58, Ben Widawsky <ben at bwidawsk.net> wrote:
>> @@ -1240,6 +1253,19 @@ intel_sprite_plane_create(struct drm_i915_private *dev_priv,
>>                 plane_formats = skl_plane_formats;
>>                 num_plane_formats = ARRAY_SIZE(skl_plane_formats);
>>                 modifiers = skl_plane_format_modifiers;
>> +       } else if (INTEL_GEN(dev_priv) >= 9) {
>> +               intel_plane->can_scale = true;
>> +               state->scaler_id = -1;
>> +
>> +               intel_plane->update_plane = skl_update_plane;
>> +               intel_plane->disable_plane = skl_disable_plane;
>> +
>> +               plane_formats = skl_plane_formats;
>> +               num_plane_formats = ARRAY_SIZE(skl_plane_formats);
>> +               if (pipe >= PIPE_C)
>
>
>if (pipe >= PIPE_C || plane >= PLANE_SPRITE1)
>
>cf. skl_check_ccs_aux_surface() which rejects CCS on anything other
>than PRIMARY/SPRITE0.
>
>I'll squash when pushing.
>
>Cheers,
>Daniel

Okay, thanks. With universal planes however, I don't think we need such a
restriction, but whatevs