[Intel-gfx] [PATCH 6/6] [v4] drm/i915: Add support for CCS modifiers

[Daniel Stone]

On 3 August 2017 at 18:21, Ben Widawsky <ben at bwidawsk.net> wrote:
> On 17-08-03 12:00:56, Daniel Stone wrote:
>> if (pipe >= PIPE_C || plane >= PLANE_SPRITE1)
>>
>> cf. skl_check_ccs_aux_surface() which rejects CCS on anything other
>> than PRIMARY/SPRITE0.
>>
>> I'll squash when pushing.
>
> Okay, thanks. With universal planes however, I don't think we need such a
> restriction, but whatevs

Speak to Ville about it, I guess? The atomic check path has this check:
        switch (plane->id) {
        case PLANE_PRIMARY:
        case PLANE_SPRITE0:
                break;
        default:
                DRM_DEBUG_KMS("RC support only on plane 1 and 2\n");
                return -EINVAL;
        }

so if we advertised it on SPRITE1/2 we'd be telling userspace to try a
configuration which could never work ...

Cheers,
Daniel