[Intel-gfx] [PATCH 05/12] drm/i915: Nuke a pointless unreachable()

Ben Widawsky ben at bwidawsk.net
Fri Aug 25 04:40:22 UTC 2017


This was specifically requested by Emil.

On 17-08-24 22:10:53, Ville Syrjälä wrote:
>From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
>The unreachable() is very much unreachable and the compiler knows
>that, so there's no point in having it.
>
>Cc: Ben Widawsky <ben at bwidawsk.net>
>Cc: Jason Ekstrand <jason at jlekstrand.net>
>Cc: Daniel Stone <daniels at collabora.com>
>Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
>---
> drivers/gpu/drm/i915/intel_display.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>index 27c1a4cbce7d..ba351cbef93b 100644
>--- a/drivers/gpu/drm/i915/intel_display.c
>+++ b/drivers/gpu/drm/i915/intel_display.c
>@@ -13078,8 +13078,6 @@ static bool intel_primary_plane_format_mod_supported(struct drm_plane *plane,
> 		return i965_mod_supported(format, modifier);
> 	else
> 		return i8xx_mod_supported(format, modifier);
>-
>-	unreachable();
> }
>
> static bool intel_cursor_plane_format_mod_supported(struct drm_plane *plane,
>-- 
>2.13.0
>

-- 
Ben Widawsky, Intel Open Source Technology Center


More information about the Intel-gfx mailing list