[Intel-gfx] [PATCH 05/12] drm/i915: Nuke a pointless unreachable()

[Emil Velikov]

On 25 August 2017 at 05:40, Ben Widawsky <ben at bwidawsk.net> wrote:
> This was specifically requested by Emil.
>
Not quite, a gist is below.

Regardless, I do not want inspire lengthy discussions over a trivial suggestion.
Please proceed as you gents prefer.

Thanks
Emil

a)Original code

if X
   return A;
else if Y
   return B;
else
   return C;

return false;

b)My suggestion

if X
   return A;
if Y
   return B;

return C;

c)Ben's counter suggestion

if X
   return A;
else if Y
   return B;
else
   return C;

unreachable();