[Intel-gfx] [RFCv2 16/19] drm/i915: Sanity check all registers for matching fw domains

[Matthew Auld]

On 20 December 2016 at 13:08, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> Add a late selftest that walks over all forcewake registers (those below
> 0x40000) and checks intel_uncore_forcewake_for_reg() that the look
I don't see where we use intel_uncore_forcewake_for_reg() ?
look ?

> exists and we having the matching powerwells.
s/having/have/

>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/selftests/intel_uncore.c | 47 +++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/selftests/intel_uncore.c b/drivers/gpu/drm/i915/selftests/intel_uncore.c
> index c18fddb12d00..c9f90514500f 100644
> --- a/drivers/gpu/drm/i915/selftests/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/selftests/intel_uncore.c
> @@ -107,6 +107,49 @@ int intel_uncore_mock_selftests(void)
>         return 0;
>  }
>
> +static int intel_uncore_check_forcewake_domains(struct drm_i915_private *dev_priv)
> +{
> +#define FW_RANGE 0x40000
> +       unsigned long *valid;
> +       u32 offset;
> +       int err;
> +
> +       valid = kzalloc(BITS_TO_LONGS(FW_RANGE) * sizeof(*valid),
> +                       GFP_TEMPORARY);
> +       if (!valid)
> +               return -ENOMEM;
> +
> +       intel_uncore_forcewake_get(dev_priv, FORCEWAKE_ALL);
> +
> +       check_for_unclaimed_mmio(dev_priv);
> +       for (offset = 0; offset < FW_RANGE; offset += 4) {
> +               i915_reg_t reg = { offset };
> +
> +               (void)I915_READ_FW(reg);
> +               if (!check_for_unclaimed_mmio(dev_priv))
> +                       set_bit(offset, valid);
> +       }
> +
> +       intel_uncore_forcewake_put(dev_priv, FORCEWAKE_ALL);
> +
> +       for_each_set_bit(offset, valid, FW_RANGE) {
> +               i915_reg_t reg = { offset };
> +
> +               intel_uncore_forcewake_reset(dev_priv, false);
> +               check_for_unclaimed_mmio(dev_priv);
> +
> +               (void)I915_READ(reg);
> +               if (check_for_unclaimed_mmio(dev_priv)) {
> +                       pr_err("Unclaimed mmio read to register 0x%04x\n",
> +                              offset);
> +                       err = -EINVAL;
> +               }
> +       }
> +
> +       kfree(valid);
> +       return err;
#undef FW_RANGE

Reviewed-by: Matthew Auld <matthew.auld at intel.com>