[Intel-gfx] [PATCH 1/2] drm/i915: Rename some warts in the VMA API

Chris Wilson chris at chris-wilson.co.uk
Mon Jan 16 10:17:17 UTC 2017

On Mon, Jan 16, 2017 at 09:49:45AM +0000, Chris Wilson wrote:
> Whilst writing testcases to exercise the VMA API, some oddities came to
> light, such as i915_gem_obj_lookup_or_create(). Joonas suggested
> i915_vma_instance() as a neat replacement, so rename them, move them to
> i915_vma.c  and add some kerneldoc as a sugary bonus.
> s/i915_gem_obj_to_vma/i915_vma_lookup/
> s/i915_gem_obj_lookup_or_create_vma/i915_vma_instance/
> Suggested-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Note that we add a lockdep check here that detects misuse during atomic
modesetting. Woohoo /o\

Chris Wilson, Intel Open Source Technology Centre

More information about the Intel-gfx mailing list