[Intel-gfx] [RFC] drm/i915/lrc: allocate separate page for HWSP

Michel Thierry michel.thierry at intel.com
Fri Jul 7 23:53:42 UTC 2017


On 07/07/17 14:15, Daniele Ceraolo Spurio wrote:
> After a bit of investigation I've found that the issue is not actually 
> with the positioning of the HWSP but with the fact that we use 
> status_page.ggtt_offset to point to the lrca offset of the default 
> context in guc_ads_create instead of using 
> kernel_context->engine[].state. With that fixed GuC works fine even with 
> the HWSP below GUC_WOPCM_TOP.

Agreed, and it's something worth fixing (regardless of what we end up 
deciding about the HWSP). ads.golden_context_lrca shouldn't be relying 
on the HWSP location.

Thanks for spotting this.

-Michel


More information about the Intel-gfx mailing list