[Intel-gfx] [PATCH 20/67] drm/i915/cnl: Cannonlake has same MOCS table than Skylake.

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Fri Jun 2 11:20:25 UTC 2017


On to, 2017-04-06 at 12:15 -0700, Rodrigo Vivi wrote:
> All registers and default configuration are the same for Skylake
> and Cannonlake.
> 
> v2: Don't apply Wa for platforms without MOCS. (Paulo)
> 
> Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

Bspec: 12239

> @@ -191,8 +191,8 @@ static bool get_mocs_settings(struct drm_i915_private *dev_priv,
>  			  "Platform that should have a MOCS table does not.\n");
>  	}
>  
> -	/* WaDisableSkipCaching:skl,bxt,kbl,glk */
> -	if (IS_GEN9(dev_priv)) {
> +	/* WaDisableSkipCaching:skl,bxt,kbl,glk,cnl */
> +	if (IS_GEN9(dev_priv) || IS_CANNONLAKE(dev_priv)) {

This is not applicable (or spec needs to be fixed). With just applying
the mocs table;

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list