[Intel-gfx] [RFC i-g-t 1/2] extended.testlist: Remove default and render engine test duplicates

Thu Jun 22 09:54:29 UTC 2017

On Fri, Jun 16, 2017 at 12:55 PM, Tvrtko Ursulin <tursulin at ursulin.net> wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>
> Where there is both default and render for the same test,
> remove the former to save some execution time.

If they are redundant, why do we even have them? Can we just remove
the testcase itself? Accumulating unused tests of questionable use at
best in igt is serious pain, because it means we never can get to a
world where new testcases are auto-added to CI withou some manual
review. And that's the world of pain we live in now and I really want
to get out of it. That means reviewing and removing testcases, not
massaging courated testlists forever, I don't think we have the time
for that among all the other tasks.

</rant> :-)

Cheers, Daniel
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> ---
>  tests/intel-ci/extended.testlist | 21 ---------------------
>  1 file changed, 21 deletions(-)
>
> diff --git a/tests/intel-ci/extended.testlist b/tests/intel-ci/extended.testlist
> index 24ec295faf66..e0926ff09bcd 100644
> --- a/tests/intel-ci/extended.testlist
> +++ b/tests/intel-ci/extended.testlist
> @@ -76,7 +76,6 @@ igt at gem_ringfill@blt-bomb
>  igt at gem_ringfill@bsd-bomb
>  igt at gem_ringfill@bsd1-bomb
>  igt at gem_ringfill@bsd2-bomb
> -igt at gem_ringfill@default-bomb
>  igt at gem_ringfill@render-bomb
>  igt at gem_ringfill@vebox-bomb
>  igt at gem_userptr_blits@stress-mm
> @@ -1154,12 +1153,10 @@ igt at gem_bad_reloc@negative-reloc-bltcopy
>  igt at gem_bad_reloc@negative-reloc-bsd
>  igt at gem_bad_reloc@negative-reloc-bsd1
>  igt at gem_bad_reloc@negative-reloc-bsd2
> -igt at gem_bad_reloc@negative-reloc-default
>  igt at gem_bad_reloc@negative-reloc-lut-blt
>  igt at gem_bad_reloc@negative-reloc-lut-bsd
>  igt at gem_bad_reloc@negative-reloc-lut-bsd1
>  igt at gem_bad_reloc@negative-reloc-lut-bsd2
> -igt at gem_bad_reloc@negative-reloc-lut-default
>  igt at gem_bad_reloc@negative-reloc-lut-render
>  igt at gem_bad_reloc@negative-reloc-lut-vebox
>  igt at gem_bad_reloc@negative-reloc-render
> @@ -1203,7 +1200,6 @@ igt at gem_cs_prefetch@blt
>  igt at gem_cs_prefetch@bsd
>  igt at gem_cs_prefetch@bsd1
>  igt at gem_cs_prefetch@bsd2
> -igt at gem_cs_prefetch@default
>  igt at gem_cs_prefetch@render
>  igt at gem_cs_prefetch@vebox
>  igt at gem_cs_tlb@blt
> @@ -1220,7 +1216,6 @@ igt at gem_ctx_bad_exec@blt
>  igt at gem_ctx_bad_exec@bsd
>  igt at gem_ctx_bad_exec@bsd1
>  igt at gem_ctx_bad_exec@bsd2
> -igt at gem_ctx_bad_exec@default
>  igt at gem_ctx_bad_exec@render
>  igt at gem_ctx_bad_exec@vebox
>  igt at gem_ctx_exec@lrc-lite-restore
> @@ -1244,7 +1239,6 @@ igt at gem_ctx_switch@bsd1
>  igt at gem_ctx_switch@bsd1-interruptible
>  igt at gem_ctx_switch@bsd2
>  igt at gem_ctx_switch@bsd2-interruptible
> -igt at gem_ctx_switch@default-interruptible
>  igt at gem_ctx_switch@render
>  igt at gem_ctx_switch@render-interruptible
>  igt at gem_ctx_switch@vebox
> @@ -1322,7 +1316,6 @@ igt at gem_exec_nop@blt
>  igt at gem_exec_nop@bsd
>  igt at gem_exec_nop@bsd1
>  igt at gem_exec_nop@bsd2
> -igt at gem_exec_nop@default
>  igt at gem_exec_nop@parallel
>  igt at gem_exec_nop@render
>  igt at gem_exec_nop@series
> @@ -1340,9 +1333,6 @@ igt at gem_exec_parallel@bsd2
>  igt at gem_exec_parallel@bsd2-contexts
>  igt at gem_exec_parallel@bsd2-fds
>  igt at gem_exec_parallel@contexts
> -igt at gem_exec_parallel@default
> -igt at gem_exec_parallel@default-contexts
> -igt at gem_exec_parallel@default-fds
>  igt at gem_exec_parallel@fds
>  igt at gem_exec_parallel@render
>  igt at gem_exec_parallel@render-contexts
> @@ -1392,7 +1382,6 @@ igt at gem_exec_reloc@active-blt
>  igt at gem_exec_reloc@active-bsd
>  igt at gem_exec_reloc@active-bsd1
>  igt at gem_exec_reloc@active-bsd2
> -igt at gem_exec_reloc@active-default
>  igt at gem_exec_reloc@active-render
>  igt at gem_exec_reloc@active-vebox
>  igt at gem_exec_schedule@deep-blt
> @@ -1431,7 +1420,6 @@ igt at gem_exec_whisper@bsd1-normal
>  igt at gem_exec_whisper@bsd2-normal
>  igt at gem_exec_whisper@chain
>  igt at gem_exec_whisper@contexts
> -igt at gem_exec_whisper@default-normal
>  igt at gem_exec_whisper@fds
>  igt at gem_exec_whisper@forked
>  igt at gem_exec_whisper@interruptible
> @@ -1682,8 +1670,6 @@ igt at gem_ringfill@bsd2
>  igt at gem_ringfill@bsd2-child
>  igt at gem_ringfill@bsd2-interruptible
>  igt at gem_ringfill@bsd2-s3
> -igt at gem_ringfill@default-child
> -igt at gem_ringfill@default-s3
>  igt at gem_ringfill@render
>  igt at gem_ringfill@render-child
>  igt at gem_ringfill@render-interruptible
> @@ -1728,26 +1714,22 @@ igt at gem_storedw_loop@long-blt
>  igt at gem_storedw_loop@long-bsd
>  igt at gem_storedw_loop@long-bsd1
>  igt at gem_storedw_loop@long-bsd2
> -igt at gem_storedw_loop@long-default
>  igt at gem_storedw_loop@long-render
>  igt at gem_storedw_loop@long-vebox
>  igt at gem_storedw_loop@short-blt
>  igt at gem_storedw_loop@short-bsd
>  igt at gem_storedw_loop@short-bsd1
>  igt at gem_storedw_loop@short-bsd2
> -igt at gem_storedw_loop@short-default
>  igt at gem_storedw_loop@short-render
>  igt at gem_storedw_loop@short-vebox
>  igt at gem_sync@blt
>  igt at gem_sync@bsd
>  igt at gem_sync@bsd1
>  igt at gem_sync@bsd2
> -igt at gem_sync@default
>  igt at gem_sync@many-blt
>  igt at gem_sync@many-bsd
>  igt at gem_sync@many-bsd1
>  igt at gem_sync@many-bsd2
> -igt at gem_sync@many-default
>  igt at gem_sync@many-render
>  igt at gem_sync@many-vebox
>  igt at gem_sync@render
> @@ -1755,7 +1737,6 @@ igt at gem_sync@store-blt
>  igt at gem_sync@store-bsd
>  igt at gem_sync@store-bsd1
>  igt at gem_sync@store-bsd2
> -igt at gem_sync@store-default
>  igt at gem_sync@store-render
>  igt at gem_sync@store-vebox
>  igt at gem_sync@vebox
> @@ -1808,7 +1789,6 @@ igt at gem_wait@busy-blt
>  igt at gem_wait@busy-bsd
>  igt at gem_wait@busy-bsd1
>  igt at gem_wait@busy-bsd2
> -igt at gem_wait@busy-default
>  igt at gem_wait@busy-render
>  igt at gem_wait@busy-vebox
>  igt at gem_wait@invalid-buf
> @@ -1817,7 +1797,6 @@ igt at gem_wait@wait-blt
>  igt at gem_wait@wait-bsd
>  igt at gem_wait@wait-bsd1
>  igt at gem_wait@wait-bsd2
> -igt at gem_wait@wait-default
>  igt at gem_wait@wait-render
>  igt at gem_wait@wait-vebox
>  igt at gem_workarounds@reset
> --
> 2.9.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch