[Intel-gfx] [RFC i-g-t 1/2] extended.testlist: Remove default and render engine test duplicates

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Thu Jun 22 10:45:40 UTC 2017


On 22/06/2017 10:54, Daniel Vetter wrote:
> On Fri, Jun 16, 2017 at 12:55 PM, Tvrtko Ursulin <tursulin at ursulin.net> wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>
>> Where there is both default and render for the same test,
>> remove the former to save some execution time.
> 
> If they are redundant, why do we even have them? Can we just remove

Maybe we can remove the default entry from intel_execution_engines 
array? And just test that default == render explicitly in a few short tests.

> the testcase itself? Accumulating unused tests of questionable use at
> best in igt is serious pain, because it means we never can get to a
> world where new testcases are auto-added to CI withou some manual
> review. And that's the world of pain we live in now and I really want
> to get out of it. That means reviewing and removing testcases, not
> massaging courated testlists forever, I don't think we have the time
> for that among all the other tasks.
> 
> </rant> :-)

I am not a fan of the testlist neither, but thought to avoid letting 
perfect being the enemy of good, and at least do something until the 
final solution crystallizes.

Regards,

Tvrtko


More information about the Intel-gfx mailing list