[Intel-gfx] [PATCH v3] drm/i915/cmdparser: Limit clflush to active cachelines

Chris Wilson chris at chris-wilson.co.uk
Fri Mar 10 13:19:21 UTC 2017


On Fri, Mar 10, 2017 at 02:41:16PM +0200, Mika Kuoppala wrote:
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > We only need to clflush those cachelines that we have validated to be
> > read by the GPU. Userspace typically fills the batch length in
> > correctly, the exceptions tend to be explicit tests within igt.
> >
> > v2: Use ptr_mask_bits() to make Mika happy
> > v3: cmd is not advanced on MI_BBE, so make sure to include an extra
> > dword in the clflush.
> >
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> I am now very happy.
> Reviewed-by: Mika Kuoppala <mika.kuoppala at intel.com>

And after all that I pushed without adding the r-b. :(

I should go and crawl underneath a rock.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list