[Intel-gfx] [PATCH v7 05/21] drm/i915/slpc: Sanitize GuC version

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Wed Mar 22 15:30:27 UTC 2017


On ke, 2017-03-22 at 16:18 +0100, Michal Wajdeczko wrote:
> On Wed, Mar 22, 2017 at 03:33:38PM +0530, Sagar Arun Kamble wrote:
> > @@ -130,6 +130,8 @@ struct intel_uc_fw {
> >  	uint32_t ucode_offset;
> >  };
> >  
> > +#define FIRMWARE_URL  "https://01.org/linuxgraphics/intel-linux-gr
> > aphics-firmwares"
> 
> Is it ok that we use such generic macro name without any intel/i915
> prefix?

Definitely not, this is result of moving from .c to .h. Need to add
I915_ prefix.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list