[Intel-gfx] [PATCH v7 05/21] drm/i915/slpc: Sanitize GuC version

Kamble, Sagar A sagar.a.kamble at intel.com
Thu Mar 23 04:54:45 UTC 2017


Thanks Joonas, Michal. Will update this patch.

On 3/22/2017 9:00 PM, Joonas Lahtinen wrote:
> On ke, 2017-03-22 at 16:18 +0100, Michal Wajdeczko wrote:
>> On Wed, Mar 22, 2017 at 03:33:38PM +0530, Sagar Arun Kamble wrote:
>>> @@ -130,6 +130,8 @@ struct intel_uc_fw {
>>>   	uint32_t ucode_offset;
>>>   };
>>>   
>>> +#define FIRMWARE_URL  "https://01.org/linuxgraphics/intel-linux-gr
>>> aphics-firmwares"
>> Is it ok that we use such generic macro name without any intel/i915
>> prefix?
> Definitely not, this is result of moving from .c to .h. Need to add
> I915_ prefix.
>
> Regards, Joonas



More information about the Intel-gfx mailing list