[Intel-gfx] [PATCH] drm/i915/guc: limit forcewake to blitter domain in guc_send

Kamble, Sagar A sagar.a.kamble at intel.com
Fri Mar 24 15:42:13 UTC 2017


Reviewed-by: Sagar Arun Kamble <sagar.a.kamble at intel.com>

On 3/24/2017 8:18 PM, Daniele Ceraolo Spurio wrote:
> The forcewake_get call in the guc_send_mmio function was added to
> avoid getting and releasing forcewake on each register access.
> While this makes sense, all GuC registers are in the blitter range
> so no need to wake all the wells.
>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> ---
>   drivers/gpu/drm/i915/intel_uc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
> index 4a872cd..e016227 100644
> --- a/drivers/gpu/drm/i915/intel_uc.c
> +++ b/drivers/gpu/drm/i915/intel_uc.c
> @@ -245,7 +245,7 @@ int intel_guc_send_mmio(struct intel_guc *guc, const u32 *action, u32 len)
>   		return -EINVAL;
>   
>   	mutex_lock(&guc->send_mutex);
> -	intel_uncore_forcewake_get(dev_priv, FORCEWAKE_ALL);
> +	intel_uncore_forcewake_get(dev_priv, FORCEWAKE_BLITTER);
>   
>   	dev_priv->guc.action_count += 1;
>   	dev_priv->guc.action_cmd = action[0];
> @@ -283,7 +283,7 @@ int intel_guc_send_mmio(struct intel_guc *guc, const u32 *action, u32 len)
>   	}
>   	dev_priv->guc.action_status = status;
>   
> -	intel_uncore_forcewake_put(dev_priv, FORCEWAKE_ALL);
> +	intel_uncore_forcewake_put(dev_priv, FORCEWAKE_BLITTER);
>   	mutex_unlock(&guc->send_mutex);
>   
>   	return ret;

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20170324/a3d7265f/attachment.html>


More information about the Intel-gfx mailing list