[Intel-gfx] New "RPM wakelock ref not held during HW access" in 4.12-rc1 ?

[Hans de Goede]

Hi,

On 18-05-17 15:59, Hans de Goede wrote:
> Hi,
> 
> On 16-05-17 12:34, Jani Nikula wrote:
>> On Tue, 16 May 2017, Ville Syrjälä <ville.syrjala at linux.intel.com> wrote:
>>> mn Tue, May 16, 2017 at 10:47:48AM +0300, Jani Nikula wrote:
>>>> On Mon, 15 May 2017, Hans de Goede <hdegoede at redhat.com> wrote:
>>>>> Hi,
>>>>>
>>>>> I'm seeing this on suspend/resume on a GPD-win,
>>>>> cherrytrail z8700 device:

<snip>

>>> ebf5f921478b ("drm/i915: Stop pretending to mask/unmask LPE audio
>>> interrupts") is a more likely candidate.
> 
> I can confirm that that patch does fix this.
> 
>> Is that applicable to v4.12-rc1?
> 
> I added it to my 4.12-rc1 based tree with a simple git cherry-pick
> without any conflicts, so from a does it apply pov yes it is
> applicable. If it is a good idea to merge it into 4.12-rc#, I don't
> know.

I've been running with commit ebf5f921478b cherry picked into my
kernel for a while now on multiple Bay and Cherry Trail devices,
and it fixes the below oops on suspend resume.

Can we get this commit cherry-picked into fixes please ?

Note this is masking the other oops I reported since we only report
one of these per suspend/resume, which is likely why no-one else is
reporting the other oops.

Regards,

Hans


>>>>> [   75.514651] RPM wakelock ref not held during HW access
>>>>> [   75.514827] ------------[ cut here ]------------
>>>>> [   75.515025] WARNING: CPU: 2 PID: 1832 at drivers/gpu/drm/i915/intel_drv.h:1780 fwtable_write32+0x1d3/0x240 [i915]
>>>>> ...
>>>>> [   75.515704] RIP: 0010:fwtable_write32+0x1d3/0x240 [i915]
>>>>> ...
>>>>> [   75.515767] Call Trace:
>>>>> [   75.515952]  lpe_audio_irq_unmask+0x6a/0xc0 [i915]
>>>>> [   75.515972]  irq_enable+0x3a/0x50
>>>>> [   75.515984]  __enable_irq+0x34/0x60
>>>>> [   75.515996]  resume_irqs+0x8f/0xd0
>>>>> [   75.516007]  resume_device_irqs+0x10/0x20
>>>>> [   75.516021]  dpm_resume_noirq+0x23e/0x310
>>>>> [   75.516041]  suspend_devices_and_enter+0x2f3/0x7f0
>>>>> [   75.516055]  ? finish_wait+0x80/0x80
>>>>> [   75.516067]  pm_suspend+0x335/0x3a0
>>>>> [   75.516078]  state_store+0x85/0xf0
>>>>> [   75.516095]  kobj_attr_store+0xf/0x20
>>>>> [   75.516108]  sysfs_kf_write+0x37/0x40
>>>>> [   75.516117]  kernfs_fop_write+0x11c/0x1a0
>>>>> [   75.516132]  __vfs_write+0x37/0x160
>>>>> [   75.516145]  ? selinux_file_permission+0xfb/0x120
>>>>> [   75.516158]  ? security_file_permission+0x3b/0xc0
>>>>> [   75.516169]  vfs_write+0xb1/0x1a0
>>>>> [   75.516180]  SyS_write+0x55/0xc0
>>>>> [   75.516197]  entry_SYSCALL_64_fastpath+0x1a/0xa5
>>>>> ...
>>>>> [   76.584235] PM: early resume of devices complete after 1067.477 msecs
>>>>>
>>>>> If someone has a fix for this they want me to try, let me know.
>>>>>
>>>>> Regards,
>>>>>
>>>>> Hans
>>>>> _______________________________________________
>>>>> Intel-gfx mailing list
>>>>> Intel-gfx at lists.freedesktop.org
>>>>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>>>
>>>> -- 
>>>> Jani Nikula, Intel Open Source Technology Center
>>