[Intel-gfx] [PATCH v5 2/2] drm/i915: Make GuC log part of the uC error state

Chris Wilson chris at chris-wilson.co.uk
Wed Oct 25 11:11:25 UTC 2017


Quoting Michal Wajdeczko (2017-10-25 11:41:12)
> We keep details of GuC and HuC in separate error state struct.
> Make GuC log part of it to group all related data together.

The only significant change would appear to placement in error-state; it
now comes at the end. Maybe that's ok; what do we feel is the relevance
of the guc log vs the dumping of user buffers? Do we want to read the
log first, or are we likely to skip to the userstate and then jump back?

At least the consideration is worthy of comment in the changelog.
-Chris


More information about the Intel-gfx mailing list