[Intel-gfx] [PATCH v5 2/2] drm/i915: Make GuC log part of the uC error state

[Michal Wajdeczko]

On Wed, 25 Oct 2017 13:11:25 +0200, Chris Wilson  
<chris at chris-wilson.co.uk> wrote:

> Quoting Michal Wajdeczko (2017-10-25 11:41:12)
>> We keep details of GuC and HuC in separate error state struct.
>> Make GuC log part of it to group all related data together.
>
> The only significant change would appear to placement in error-state; it
> now comes at the end. Maybe that's ok; what do we feel is the relevance
> of the guc log vs the dumping of user buffers? Do we want to read the
> log first, or are we likely to skip to the userstate and then jump back?

I would expect data in error-state to be grouped always per "source" to
easy track what is available from it. Also ordering of these sources can
be based on the order driver is using/creating them (ie. pciid, modparams,
device flags, uc, engines, buffers... - which is different than today's)

>
> At least the consideration is worthy of comment in the changelog.

Ok, I'll add small note.

Michal