[Intel-gfx] [PATCH] i915: Fix obj size vs. alignment for drm_pci_alloc()

Chris Wilson chris at chris-wilson.co.uk
Thu Sep 7 14:43:26 UTC 2017


Quoting ville.syrjala at linux.intel.com (2017-09-07 15:32:03)
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> drm_pci_alloc() refuses to cooperate if the passed alignment exceeds the
> object size. So round up the obj size to the next power of two as well
> to make this actually work.

'Tis true.

> to begin with. However kms_cursor_crc doesn't always use power of two
> sizes so we hit a failure when we try to allocate the phys memory.
> 
> Testcase: igt/kms_cursor_crc
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Shouldn't we remove the restriction from drm_pci.c? Seem like it is
second guessing the actual dma allocator. We should just kill it
entirely...
-Chris


More information about the Intel-gfx mailing list