[Intel-gfx] [PATCH] i915: Fix obj size vs. alignment for drm_pci_alloc()

[Ville Syrjälä]

On Thu, Sep 07, 2017 at 03:43:26PM +0100, Chris Wilson wrote:
> Quoting ville.syrjala at linux.intel.com (2017-09-07 15:32:03)
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > drm_pci_alloc() refuses to cooperate if the passed alignment exceeds the
> > object size. So round up the obj size to the next power of two as well
> > to make this actually work.
> 
> 'Tis true.
> 
> > to begin with. However kms_cursor_crc doesn't always use power of two
> > sizes so we hit a failure when we try to allocate the phys memory.
> > 
> > Testcase: igt/kms_cursor_crc
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> Shouldn't we remove the restriction from drm_pci.c? Seem like it is
> second guessing the actual dma allocator. We should just kill it
> entirely...

Perhaps. I was feeling lazy today though so left it at this.

-- 
Ville Syrjälä
Intel OTC