[Intel-gfx] [PATCH v2 4/5] drm/i915: Wrap access to module params into macro

Jani Nikula jani.nikula at linux.intel.com
Thu Sep 14 13:10:22 UTC 2017


On Thu, 14 Sep 2017, Michal Wajdeczko <michal.wajdeczko at intel.com> wrote:
> @@ -1031,9 +1031,9 @@ static void i915_driver_cleanup_mmio(struct drm_i915_private *dev_priv)
>  
>  static void intel_sanitize_options(struct drm_i915_private *dev_priv)
>  {
> -	i915.enable_execlists =
> +	i915_param(enable_execlists) =

I disapprove using a function-like macro expansion as an lvalue. If you
want to use a getter macro, also provide a setter, and use them
separately.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list