[Intel-gfx] [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

[Widawsky, Benjamin]

Juvenile no 00


-------- Original message --------
From: "Wang, Zhi A" <zhi.a.wang at intel.com>
Date: 9/14/17 8:03 PM (GMT-08:00)
To: Chris Wilson <chris at chris-wilson.co.uk>, "Vivi, Rodrigo" <rodrigo.vivi at intel.com>
Cc: intel-gfx at lists.freedesktop.org, intel-gvt-dev at lists.freedesktop.org, joonas.lahtinen at linux.intel.com, zhenyuw at linux.intel.com, "Widawsky, Benjamin" <benjamin.widawsky at intel.com>
Subject: RE: [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

Sorry for the trouble. It's because we have 4 different entries with different attributes and every time we match an entry by cache attribute, we got a perfect match...

-----Original Message-----
From: Chris Wilson [mailto:chris at chris-wilson.co.uk]
Sent: Thursday, September 14, 2017 9:41 PM
To: Vivi, Rodrigo <rodrigo.vivi at intel.com>; Wang, Zhi A <zhi.a.wang at intel.com>
Cc: intel-gfx at lists.freedesktop.org; intel-gvt-dev at lists.freedesktop.org; joonas.lahtinen at linux.intel.com; zhenyuw at linux.intel.com; Widawsky, Benjamin <benjamin.widawsky at intel.com>
Subject: Re: [PATCH 1/2] drm/i915: Fix a typo in i915_ppat_get()

Quoting Rodrigo Vivi (2017-09-14 18:36:49)
>
> well, I wouldn't call this as a typo.
> This is a logic fix and deserves a better subject a proper commit
> message an also fixes tag:

It should work either way, just the bug doesn't allow reuse.

The question to ask is why didn't the selftest pick this up? It passes on bdw...
-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20170915/2695ee94/attachment.html>