[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v4] drm/i915: Enable edp psr error interrupts on hsw (rev3)

[Rodrigo Vivi]

On Tue, Apr 10, 2018 at 12:49:25AM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [v4] drm/i915: Enable edp psr error interrupts on hsw (rev3)
> URL   : https://patchwork.freedesktop.org/series/41095/
> State : warning
> 
> == Summary ==
> 
> $ dim checkpatch origin/drm-tip
> 0a22dbbae8f8 drm/i915: Enable edp psr error interrupts on hsw
> -:111: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
> #111: FILE: drivers/gpu/drm/i915/i915_reg.h:4032:
> +#define   EDP_PSR_ERROR				(1<<2)
>                         				  ^
> 
> -:112: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
> #112: FILE: drivers/gpu/drm/i915/i915_reg.h:4033:
> +#define   EDP_PSR_POST_EXIT			(1<<1)
>                             			  ^
> 
> -:113: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
> #113: FILE: drivers/gpu/drm/i915/i915_reg.h:4034:
> +#define   EDP_PSR_PRE_ENTRY			(1<<0)
>                             			  ^
> 
> -:122: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
> #122: FILE: drivers/gpu/drm/i915/i915_reg.h:6847:
> +#define DE_EDP_PSR_INT_HSW		(1<<19)
>                            		  ^
> 
> total: 0 errors, 0 warnings, 4 checks, 78 lines checked
> 7fdf2eed9ed4 drm/i915: Enable edp psr error interrupts on bdw+
> -:159: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
> #159: FILE: drivers/gpu/drm/i915/intel_display.h:221:
> +#define for_each_cpu_transcoder_masked(__dev_priv, __t, __mask) \
> +	for ((__t) = 0; (__t) < I915_MAX_TRANSCODERS; (__t)++)	\
> +		for_each_if ((__mask) & (1 << (__t)))

This showed up on red on dim when I was going to push here...

DK, could you please address this one here before we can push?

Thanks,
Rodrigo.

> 
> -:159: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__t' - possible side-effects?
> #159: FILE: drivers/gpu/drm/i915/intel_display.h:221:
> +#define for_each_cpu_transcoder_masked(__dev_priv, __t, __mask) \
> +	for ((__t) = 0; (__t) < I915_MAX_TRANSCODERS; (__t)++)	\
> +		for_each_if ((__mask) & (1 << (__t)))
> 
> -:160: CHECK:SPACING: No space is necessary after a cast
> #160: FILE: drivers/gpu/drm/i915/intel_display.h:222:
> +	for ((__t) = 0; (__t) < I915_MAX_TRANSCODERS; (__t)++)	\
> 
> -:161: WARNING:SPACING: space prohibited between function name and open parenthesis '('
> #161: FILE: drivers/gpu/drm/i915/intel_display.h:223:
> +		for_each_if ((__mask) & (1 << (__t)))
> 
> total: 1 errors, 1 warnings, 2 checks, 123 lines checked
> 003ec0005027 drm/i915/psr: Control PSR interrupts via debugfs
> d8186b823b62 drm/i915/psr: Timestamps for PSR entry and exit interrupts.
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx