[Intel-gfx] [PATCH] drm: More debug info for fb leaks in mode_config_cleanup

[Thomas Hellstrom]

Hi,

On 12/07/2017 03:49 PM, Daniel Vetter wrote:
> We're spotting this very rarely in CI, but have no idea. Let's add
> more debug info about what's going on here.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=102707
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
>   drivers/gpu/drm/drm_mode_config.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c
> index cc78b3d9e5e4..6ffe952142e6 100644
> --- a/drivers/gpu/drm/drm_mode_config.c
> +++ b/drivers/gpu/drm/drm_mode_config.c
> @@ -469,6 +469,9 @@ void drm_mode_config_cleanup(struct drm_device *dev)
>   	 */
>   	WARN_ON(!list_empty(&dev->mode_config.fb_list));
>   	list_for_each_entry_safe(fb, fbt, &dev->mode_config.fb_list, head) {
> +		struct drm_printer p = drm_debug_printer("[leaked fb]");
> +		drm_printf(&p, "framebuffer[%u]:\n", fb->base.id);
> +		drm_framebuffer_print_info(&p, 1, fb);
>   		drm_framebuffer_free(&fb->base.refcount);
>   	}
>   

Did we ever get to the bottom of what's causing those framebuffer leaks? 
We've seen sporadic framebuffer leaks when transitioning between one and 
two screens, but can't seem to repro with the latest drm-fixes branch?

Thanks,

Thomas