[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: kill intel_display_power_well_is_enabled()

[Paulo Zanoni]

Em Qua, 2018-08-08 às 22:22 +0000, Patchwork escreveu:
> == Series Details ==
> 
> Series: series starting with [1/4] drm/i915: kill
> intel_display_power_well_is_enabled()
> URL   : https://patchwork.freedesktop.org/series/47908/
> State : warning
> 
> == Summary ==
> 
> $ dim checkpatch origin/drm-tip
> 94cddb6f9752 drm/i915: kill intel_display_power_well_is_enabled()
> dfb09a8944b0 drm/i915: BUG() if we can't lookup_power_well()
> -:31: WARNING:AVOID_BUG: Avoid crashing the kernel - try using
> WARN_ON & recovery code rather than BUG() or BUG_ON()
> #31: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:1124:
> +	BUG();

See the commit message of patch 2, Mr. Robot. I don't think it's worth
adding checking code in the callers, and replacing the current null
pointer dereference with a BUG() is an improvement IMHO.

If anybody disagrees with this, please say so.

> 
> total: 0 errors, 1 warnings, 0 checks, 9 lines checked
> e5298551c379 drm/i915: use for_each_power_well in lookup_power_well()
> 942f90859025 drm/i915: move lookup_power_well() up
> -:40: WARNING:AVOID_BUG: Avoid crashing the kernel - try using
> WARN_ON & recovery code rather than BUG() or BUG_ON()
> #40: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:683:
> +	BUG();
> 
> total: 0 errors, 1 warnings, 0 checks, 50 lines checked
>