[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: kill intel_display_power_well_is_enabled()

[Michal Wajdeczko]

On Thu, 09 Aug 2018 00:58:53 +0200, Paulo Zanoni  
<paulo.r.zanoni at intel.com> wrote:

> Em Qua, 2018-08-08 às 22:22 +0000, Patchwork escreveu:
>> == Series Details ==
>>
>> Series: series starting with [1/4] drm/i915: kill
>> intel_display_power_well_is_enabled()
>> URL   : https://patchwork.freedesktop.org/series/47908/
>> State : warning
>>
>> == Summary ==
>>
>> $ dim checkpatch origin/drm-tip
>> 94cddb6f9752 drm/i915: kill intel_display_power_well_is_enabled()
>> dfb09a8944b0 drm/i915: BUG() if we can't lookup_power_well()
>> -:31: WARNING:AVOID_BUG: Avoid crashing the kernel - try using
>> WARN_ON & recovery code rather than BUG() or BUG_ON()
>> #31: FILE: drivers/gpu/drm/i915/intel_runtime_pm.c:1124:
>> +	BUG();
>
> See the commit message of patch 2, Mr. Robot. I don't think it's worth
> adding checking code in the callers, and replacing the current null
> pointer dereference with a BUG() is an improvement IMHO.
>
> If anybody disagrees with this, please say so.

other option could be to use WARN_ON to make Mr. Robot happy and
then return first/last/default power well to make callers happy

/michal