[Intel-gfx] [PATCH v2] drm/i915/vgpu: Disallow loading on old vGPU hosts

Mika Kuoppala mika.kuoppala at linux.intel.com
Mon Dec 3 16:22:52 UTC 2018


Chris Wilson <chris at chris-wilson.co.uk> writes:

> Quoting Mika Kuoppala (2018-12-03 13:40:26)
>> Chris Wilson <chris at chris-wilson.co.uk> writes:
>> 
>> > Since commit fd8526e50902 ("drm/i915/execlists: Trust the CSB") we
>> > actually broke the force-mmio mode for our execlists implementation. No
>> > one noticed, so ergo no one is actually using an old vGPU host (where we
>> > required the older method) and so can simply remove the broken support.
>> >
>> > v2: csb_read can go as well (Mika)
>> >
>> > Reported-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
>> > Fixes: fd8526e50902 ("drm/i915/execlists: Trust the CSB")
>> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
>> > Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>> > Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
>> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
>> 
>> Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
>
> Pushed, thanks. That should make your extended CSB patches for icl that
> much more straightforward, right?

Very much so. Now just have to figure out how to make the
cpu/gpu dance together. The extended CSB is not enough
by itself :(

-Mika



More information about the Intel-gfx mailing list