[Intel-gfx] [PATCH] drm/i915/execlists: Add a GEM_TRACE to show when the context is completed

[Chris Wilson]

Quoting Mika Kuoppala (2018-02-21 15:21:04)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > Include a GEM_TRACE to show when the context is complete and we advance
> > the ELSP port.
> >
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_lrc.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> > index 9b6d781b22ec..fe5a0fa3f3b6 100644
> > --- a/drivers/gpu/drm/i915/intel_lrc.c
> > +++ b/drivers/gpu/drm/i915/intel_lrc.c
> > @@ -890,6 +890,9 @@ static void execlists_submission_tasklet(unsigned long data)
> >                               trace_i915_gem_request_out(rq);
> >                               i915_gem_request_put(rq);
> >  
> > +                             GEM_TRACE("%s completed ctx=%d\n",
> > +                                       engine->name, port->context_id);
> > +
> 
> There is a trace above with a count so info is already there,
> and could be amended to output completion if count == 1.

But that assumes we don't add a bug in between. :)

What I was thinking was that we really wanted to show the port
advancement here, but not quite sure what to show. This gives us a clear
marker for something to search for that doesn't require us to know that
when count==1 we expect it to complete. Sometimes I like going easy on
myself.
-Chris